Add Thickness parameter in drawMatches function#20232
Merged
opencv-pushbot merged 1 commit intoopencv:3.4from Jun 18, 2021
Merged
Add Thickness parameter in drawMatches function#20232opencv-pushbot merged 1 commit intoopencv:3.4from
opencv-pushbot merged 1 commit intoopencv:3.4from
Conversation
f32e60d to
f097c13
Compare
This commit adds the feature of selecting the thickness of the matches drawn by the drawMatches function. In larger images, the default thickness of 1 pixel creates images that are hard to visualize.
f097c13 to
411fd2b
Compare
alalek
approved these changes
Jun 15, 2021
Member
alalek
left a comment
There was a problem hiding this comment.
Looks good to me 👍
There are some low priority questions about:
- compatibility of Python bindings (we don't check them actually)
- documentation of parameters
| const std::vector<DMatch>& matches1to2, InputOutputArray outImg, | ||
| const int matchesThickness, const Scalar& matchColor=Scalar::all(-1), | ||
| const Scalar& singlePointColor=Scalar::all(-1), const std::vector<char>& matchesMask=std::vector<char>(), | ||
| int flags=DrawMatchesFlags::DEFAULT ); |
Member
There was a problem hiding this comment.
@vpisarev I believe we should define strategy about changes which should be migrated to OpenCV 5.0 major release
Contributor
Author
There was a problem hiding this comment.
Regarding Python bindings: I've tested the code provided by the author of #20095 and it's working fine.
Regarding the documentation: the new parameter should be documented when it's only used in an overloaded function? If so, I can take a look at it.
My first try was to include it as a parameter of the original function, but some errors happened due to the function names inside of binary files, that's why I've created a new function.
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds the feature of selecting the thickness
of the matches drawn by the drawMatches function.
In larger images, the default thickness of 1 pixel creates images
that are hard to visualize.
resolves #20095
Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.