Skip to content

highgui: update backends handling, fix WITH_OPENGL=ON build#20229

Merged
opencv-pushbot merged 1 commit intoopencv:masterfrom
alalek:fix_highgui_build
Jun 7, 2021
Merged

highgui: update backends handling, fix WITH_OPENGL=ON build#20229
opencv-pushbot merged 1 commit intoopencv:masterfrom
alalek:fix_highgui_build

Conversation

@alalek
Copy link
Copy Markdown
Member

@alalek alalek commented Jun 7, 2021 •
edited
Loading

continues #20116
should fix hightly build

Build with OpenGL is supported by GTK 2.x only (through gtkglext).

Backlog: improve HAVE_OPENGL detection code (Qt backend refactoring is required).

force_builders=Custom
buildworker:Custom=linux-1,linux-2,linux-4,linux-6
build_image:Custom=qt:16.04
build_contrib:Custom=OFF

alalek
alalek commented Jun 7, 2021
View reviewed changes
modules/highgui/CMakeLists.txt
Comment on lines -7 to -9
set(HIGHGUI_PLUGIN_LIST "" CACHE STRING "List of GUI backends to be compiled as plugins (gtk, gtk2/gtk3, qt, win32 or special value 'all')")
set(HIGHGUI_ENABLE_PLUGINS "${ENABLE_PLUGINS_DEFAULT}" CACHE BOOL "Allow building and using of GUI plugins")
mark_as_advanced(HIGHGUI_PLUGIN_LIST HIGHGUI_ENABLE_PLUGINS)
Copy link
Copy Markdown
Member Author

@alalek alalek Jun 7, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

options are moved to init.cmake to use them there.

We don't need to detect all possible variants of 3rdparty backends if we don't have enabled plugins at all (e.g., line 13 of detect_gtk.cmake).

@alalek
Copy link
Copy Markdown
Member Author

alalek commented Jun 7, 2021

👍

@opencv-pushbot opencv-pushbot merged commit 993416d into opencv:master Jun 7, 2021
@alalek alalek mentioned this pull request Jun 13, 2021
Merged
@alalek alalek mentioned this pull request Oct 15, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@alalek alalek

Labels

bug category: build/install category: highgui-gui

Projects

None yet

Milestone

4.5.3

Development

Successfully merging this pull request may close these issues.

2 participants

@alalek @opencv-pushbot