highgui: fix config verification for GTK#20164
Merged
opencv-pushbot merged 1 commit intoopencv:masterfrom May 27, 2021
Merged
Conversation
alalek
approved these changes
May 26, 2021
Member
alalek
left a comment
There was a problem hiding this comment.
We need to drop CMake scope created by add_subdirectory(modules)
Contributor
Author
|
I think we can overcome scopes thing by using Alternatively, if result variables ( Root cmake script:ocv_log_section_register("other" "Other third-party libraries")
#... add modules
ocv_log_print_sections() # print whole libraries part
ocv_verify_config() # prints already evaluated resultsSomewhere in the module:if(WITH_LIB_X)
#... detect something
set(HAVE_LIB_X 1)
endif()
if(WITH_LIB_X OR HAVE_LIB_X)
ocv_log_status(SECTION "other" MSG "LibraryX:" HAVE_LIB_X THEN "YES" ELSE "NO")
endif()
ocv_verify_option(WITH_LIB_X BY HAVE_LIB_X) |
This was referenced May 31, 2021
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related #20116
There was a configuration problem with
ENABLE_CONFIG_VERIFICATION=ONoption becauseHAVE_GTK3variable was not set.opencv/CMakeLists.txt
Lines 275 to 277 in 830cb5c