Skip to content

aravis-8.0 is NOW compatible.#20126

Closed
jiapei100 wants to merge 0 commit intoopencv:4.xfrom
LongerVision:master
Closed

aravis-8.0 is NOW compatible.#20126
jiapei100 wants to merge 0 commit intoopencv:4.xfrom
LongerVision:master

Conversation

@jiapei100
Copy link
Copy Markdown

@jiapei100 jiapei100 commented May 20, 2021 •
edited
Loading

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or other license that is incompatible with OpenCV
  • The PR is proposed to proper branch
  • There is reference to original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@mshabunin
Copy link
Copy Markdown
Contributor

mshabunin commented May 20, 2021

Is it possible to make the code compatible with both old and new versions with help of preprocessor macros?

@asmorkalov
Copy link
Copy Markdown
Contributor

asmorkalov commented May 21, 2021

/cc @ArkadiuszRaj

@ArkadiuszRaj
Copy link
Copy Markdown
Contributor

ArkadiuszRaj commented May 21, 2021

Absolutely I am fan of supporting both old and new Aravis versions.
Preprocessor in this case is enough, however this new method with "error" variable is better when it comes to detection cause of error.

@asmorkalov
Copy link
Copy Markdown
Contributor

asmorkalov commented Jun 1, 2021

@jiapei100 Do you have progress with the patch?

@jiapei100
Copy link
Copy Markdown
Author

jiapei100 commented Jun 4, 2021

@asmaloney
Sorry I myself haven't been using Windows for over 15 years, and NOW I ONLY have Ubuntu 20.04 on my computer. So, I think Ubuntu 18.04 or Windows 10 won't be given any support from me.

It looks RISC-V and Ubuntu 20.04 are now built successfully with aravis--8, which is good enough...

Cheers

@asmaloney
Copy link
Copy Markdown
Contributor

asmaloney commented Jun 4, 2021

@jiapei100 I think you meant that for @asmorkalov.

@asmorkalov
Copy link
Copy Markdown
Contributor

asmorkalov commented Jun 10, 2021

@jiapei100 Friendly reminder. Please ignore non-default CI items for now. They are optional.

@asmorkalov asmorkalov mentioned this pull request Jul 6, 2021
Merged
6 tasks
@asmorkalov
Copy link
Copy Markdown
Contributor

asmorkalov commented Sep 29, 2021

@jiapei100 Friendly reminder

@mshabunin
Copy link
Copy Markdown
Contributor

mshabunin commented Sep 29, 2021

@asmorkalov , I think we should accept PR #20363 instead of this one. While both are breaking compatibility with Aravis 0.6, that one uses NULL instead of a dummy variable and removes some deprecated things.

@jiapei100 jiapei100 closed this Dec 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

category: build/install category: videoio category: 3rdparty feature incomplete

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@jiapei100 @mshabunin @asmorkalov @ArkadiuszRaj @asmaloney @alalek