Merged
Conversation
0b193a4 to
30cac00
Compare
30cac00 to
d43f3fa
Compare
44a42d8 to
9de5c4b
Compare
vpisarev
approved these changes
May 19, 2021
| Mat &converted_src1 = test_mat[TEMP][0]; | ||
| Mat &converted_src2 = test_mat[TEMP][1]; | ||
| convert_from_ccs( src1, src1, converted_src1, flags ); | ||
| convert_from_ccs( src2, src2, converted_src2, flags ); |
There was a problem hiding this comment.
I'd like to see convert_from_ccs and convert_to_ccs as public functions as well. Why do you pass in two src matrices to this function?
Contributor
Author
There was a problem hiding this comment.
I think it's a good idea to make them public if they're going to be used elsewhere. Also, the exact same conversion is used in test_dxt.cpp.
Only a single src matrix needs to be passed in for the end user. The presence of two src args is for the recursive call on line 260. Perhaps the public api can be improved to only accept a single src matrix.
4 tasks
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make the function divSpectrums public. A unit test to verify the function for supported input types and flags is added.
This feature is requested in #19767.
Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.