Skip to content

Update dnn.hpp#20080

Merged
alalek merged 2 commits intoopencv:3.4from
pauljurczak:patch-3
Jun 2, 2021
Merged

Update dnn.hpp#20080
alalek merged 2 commits intoopencv:3.4from
pauljurczak:patch-3

Conversation

@pauljurczak
Copy link
Copy Markdown
Contributor

@pauljurczak pauljurczak commented May 13, 2021

getPerfProfile is not supported by the CUDA backend, see #20077

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or other license that is incompatible with OpenCV
  • The PR is proposed to proper branch
  • There is reference to original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

/** @brief Returns overall time for inference and timings (in ticks) for layers.
* Indexes in returned vector correspond to layers ids. Some layers can be fused with others,
* in this case zero ticks count will be return for that skipped layers.
* in this case zero ticks count will be return for that skipped layers. Not supported by CUDA backend.
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe OpenCV/CPU backend only supports this method properly.
Other backends are asynchronous (like OpenCL, CUDA) or they don't provide per-layer information because tasks are scheduled as sub-graphs.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have that knowledge. It would be helpful to indicate limited backend support, so no one else wastes time to find out the hard way.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be:

... DNN_BACKEND_OPENCV on DNN_TARGET_CPU only.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I corrected it.

@asmorkalov
Copy link
Copy Markdown
Contributor

asmorkalov commented Jun 1, 2021

@pauljurczak Any progress with the patch?

@asmorkalov asmorkalov added the category: documentation Documentation fix or update label Jun 2, 2021
@asmorkalov asmorkalov requested a review from alalek June 2, 2021 06:53
Copy link
Copy Markdown
Member

@alalek alalek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 👍

pauljurczak and others added 2 commits June 2, 2021 17:51
getPerfProfile is not supported by the CUDA backend, see opencv#20077
@alalek alalek merged commit ff60abb into opencv:3.4 Jun 2, 2021
This was referenced Jun 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category: dnn category: documentation Documentation fix or update

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants