Skip to content

Added QRCodeDetector to excludes#20037

Closed
asenyaev wants to merge 1 commit intoopencv:3.4from
asenyaev:asen/qrcodedetector
Closed

Added QRCodeDetector to excludes#20037
asenyaev wants to merge 1 commit intoopencv:3.4from
asenyaev:asen/qrcodedetector

Conversation

@asenyaev
Copy link
Copy Markdown
Contributor

@asenyaev asenyaev commented May 5, 2021

This PR fixes the issue with java tests on ARM.

As an example of this failure I provide a log in Jenkins: https://build.opencv.org.cn/job/precommit/job/ubuntu-20.04-arm64/1784/console

Related issues: #19172, #19173

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or other license that is incompatible with OpenCV
  • The PR is proposed to proper branch
  • There is reference to original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

Copy link
Copy Markdown
Member

@alalek alalek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. We should not disable test everywhere, just because it doesn't work on ARM.
  2. We can detect "ARM" platform in the Java test and then skip checks (add comment with link on the corresponding issue).
  3. Or make it configurable (with external parameters on builders). Something like #14633

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants