Extract IE version from IE cmake config#20026
Merged
alalek merged 2 commits intoopencv:masterfrom May 24, 2021
Merged
Conversation
3f58b7a to
1fc23f6
Compare
mshabunin
reviewed
May 4, 2021
b1b5660 to
4772981
Compare
mshabunin
approved these changes
May 4, 2021
alalek
reviewed
May 5, 2021
Member
alalek
left a comment
There was a problem hiding this comment.
Looks good to me 👍
Please remove "draft" status when PR is ready.
| if(INF_ENGINE_TARGET) | ||
| if(InferenceEngine_VERSION VERSION_GREATER_EQUAL "2021.4") | ||
| math(EXPR INF_ENGINE_RELEASE "${InferenceEngine_VERSION_MAJOR} * 1000000 + ${InferenceEngine_VERSION_MINOR} * 10000 + ${InferenceEngine_VERSION_PATCH} * 100") | ||
| endif() |
Member
There was a problem hiding this comment.
BTW, It makes sense to emit warning if there is passed wrong value through CMake's command-line (need to think how to ignore/handle "patch" version here in this comparison).
(backlog)
alalek
approved these changes
May 17, 2021
Member
@ilya-lavrenov Is this PR ready? |
4772981 to
cddfa82
Compare
Co-authored-by: Maksim Shabunin <maksim.shabunin@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.
Based on ilya-lavrenov/openvino#19 which is going to be merged after openvinotoolkit/openvino#5484
CC @dkurt @alalek, please, comment before we commit changes to OpenVINO