Stream default to Stream::Null() when no default in function prototype#20019
Stream default to Stream::Null() when no default in function prototype#20019opencv-pushbot merged 1 commit intoopencv:masterfrom
Conversation
9ea3b9d to
919396e
Compare
|
Thank you for contribution! It would be nice if you could add simple test here: https://github.com/opencv/opencv/blob/4.5.2/modules/python/test/test_cuda.py |
|
Hello @alalek what kind of test do you need ?
I have a second question. My fix looks like a hack. Here is the problem creating the bug. Other functions are using a default value in the C++ function prototype: But this is not possible for So patching |
|
jenkins cn please retry a build |
alalek
left a comment
There was a problem hiding this comment.
There is already .upload check. More accurate test is hard to write.
The patch looks good to me 👍
|
Please remove "WIP: " when patch is ready (BTW, you can use GitHub's "drafts" instead) |
this corrects bug opencv#16592 where a Stream is created at each GpuMat::load(arr,stream) call a correct solution would have been to add a default to GpuMat::load but due to circular dependence between Stream and GpuMat, this is not possible add test_cuda_upload_download_stream to test_cuda.py
|
Hello @alalek I added a Running |
this corrects bug #16592 where a Stream is created at
each GpuMat::load(arr,stream) call
a correct solution would have been to add a default to GpuMat::load
but due to circular dependence between Stream and GpuMat, this is not possible
Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.
Details