Skip to content

[build][option] Build option to disable filesystem support.#20010

Merged
opencv-pushbot merged 1 commit intoopencv:masterfrom
fpetrogalli:disable_filesystem
May 11, 2021
Merged

[build][option] Build option to disable filesystem support.#20010
opencv-pushbot merged 1 commit intoopencv:masterfrom
fpetrogalli:disable_filesystem

Conversation

@fpetrogalli
Copy link
Copy Markdown
Contributor

@fpetrogalli fpetrogalli commented Apr 29, 2021 •
edited
Loading

As part of factoring out work from #19921 , I have created a cmake option to disable filesystem support. I extracted the macro OPENCV_HAVE_FILESYSTEM_SUPPORT as mentioned in the TODO associated to the macro.

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or other license that is incompatible with OpenCV
  • The PR is proposed to proper branch
  • There is reference to original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake
force_builders=linux,docs,ARMv8,ARMv7

@fpetrogalli fpetrogalli force-pushed the disable_filesystem branch 4 times, most recently from 642425c to ec8b8b1 Compare April 30, 2021 10:59
alalek
alalek reviewed Apr 30, 2021
View reviewed changes
alalek
alalek reviewed May 1, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@alalek alalek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for update! Now looks much better.

@fpetrogalli fpetrogalli force-pushed the disable_filesystem branch 2 times, most recently from 1c46d51 to 610d676 Compare May 4, 2021 17:03
@fpetrogalli
Copy link
Copy Markdown
Contributor Author

fpetrogalli commented May 4, 2021

With the last update, I have disable filesystem support also in modules/core/src/utils/datafile.cpp.

@fpetrogalli
Copy link
Copy Markdown
Contributor Author

fpetrogalli commented May 6, 2021

@vpisarev @alalek - gentle ping on this, as the failures in the CN builders seem to be unrelated to the changes introduced in this patch.

@fpetrogalli fpetrogalli mentioned this pull request May 6, 2021
Merged
6 tasks
alalek
alalek reviewed May 6, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@alalek alalek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done!

Please take a look on comments below.

@fpetrogalli fpetrogalli force-pushed the disable_filesystem branch from 610d676 to 0511eb4 Compare May 6, 2021 14:06
@fpetrogalli
Copy link
Copy Markdown
Contributor Author

fpetrogalli commented May 6, 2021

@alalek - thank you for the review! I have addressed you comments, plus I have touched other places in the source were the baremetal code at #19921 was still needing filesystem specific routines (for example, mkstemp).

@fpetrogalli fpetrogalli force-pushed the disable_filesystem branch 2 times, most recently from 05cf802 to 4633e89 Compare May 7, 2021 09:47
@fpetrogalli
Copy link
Copy Markdown
Contributor Author

fpetrogalli commented May 7, 2021

@alalek - I just submitted a whitespace fix to prevent the failure at https://pullrequest.opencv.org/buildbot/builders/precommit_docs/builds/30324/steps/whitespace%20opencv

Francesco

@fpetrogalli fpetrogalli mentioned this pull request May 11, 2021
Closed
6 tasks
@fpetrogalli fpetrogalli force-pushed the disable_filesystem branch from 4633e89 to 7a31a6e Compare May 11, 2021 12:55
alalek
alalek approved these changes May 11, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@alalek alalek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done! Thank you for contribution 👍

@opencv-pushbot opencv-pushbot merged commit 7ffc022 into opencv:master May 11, 2021
@kikaxa kikaxa mentioned this pull request May 20, 2021
Merged
6 tasks
@alalek alalek mentioned this pull request Jun 4, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alalek alalek alalek approved these changes

@vpisarev vpisarev Awaiting requested review from vpisarev

Assignees

@alalek alalek

Labels

category: build/install category: core feature

Projects

None yet

Milestone

4.5.3

Development

Successfully merging this pull request may close these issues.

4 participants

@fpetrogalli @kikaxa @alalek @opencv-pushbot