Fix unsigned int bug in computeECC#19993
Merged
alalek merged 4 commits intoopencv:3.4from Apr 30, 2021
Merged
Conversation
alalek
reviewed
Apr 29, 2021
Member
alalek
left a comment
There was a problem hiding this comment.
Well done! Thank you for contribution
modules/video/src/ecc.cpp
Outdated
| */ | ||
| if(type == CV_8U) { | ||
| templateMat.convertTo(templateMat, CV_16S); | ||
| inputMat.convertTo(inputMat, CV_16S); |
Member
There was a problem hiding this comment.
Please avoid inplace src / dst parameters.
Current implementation is ineffective (extra copy can be done due to non-inplace operation).
Use swap() to update "local" Mat.
Contributor
Author
There was a problem hiding this comment.
Done - thank you!
alalek
approved these changes
Apr 30, 2021
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #14657. The problem in the original issue was they were using unsigned int values. This causes problems in the ECC computation, as subtracting the mean will result in certain being 0 instead of negative, and this impacts the dot product / norm.
I know this isn't pretty - the alternative solution is just raise an exception if a matrix of type
CV_8UorCV_16Uis supplied.Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.