Merged
Conversation
alalek
reviewed
Apr 26, 2021
modules/dnn/CMakeLists.txt
Outdated
| ocv_option(OPENCV_DNN_PERF_CLCAFFE "Add performance tests of clCaffe framework" OFF) | ||
| if(BUILD_PERF_TESTS) | ||
| if (${the_module}_PERF_CAFFE) | ||
| if (OPENCV_DNN_PERF_CAFFE) |
Member
There was a problem hiding this comment.
Please provide compatibility shim for old variables too:
if (OPENCV_DNN_PERF_CAFFE
OR ${the_module}_PERF_CAFFE # compatibility for deprecated option
)
Or emit warning about removed variables through ocv_declare_removed_variable / ocv_declare_removed_variables (less compatible, probably should go to the "next" branch only)
alalek
approved these changes
Apr 28, 2021
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
opencv_dnn_PERF_CAFFE -> OPENCV_DNN_PERF_CAFFE
opencv_dnn_PERF_CLCAFFE -> OPENCV_DNN_PERF_CLCAFFE
these two options appears in a seperated group in cmake GUI when grouped.