Skip to content

Fix link#19979

Merged
opencv-pushbot merged 1 commit intoopencv:3.4from
micha137:patch-3
Apr 27, 2021
Merged

Fix link#19979
opencv-pushbot merged 1 commit intoopencv:3.4from
micha137:patch-3

Conversation

@micha137
Copy link
Copy Markdown
Contributor

@micha137 micha137 commented Apr 26, 2021 •
edited
Loading

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or other license that is incompatible with OpenCV
  • The PR is proposed to proper branch
  • There is reference to original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@micha137 micha137 closed this Apr 26, 2021
@micha137 micha137 reopened this Apr 26, 2021
@alalek
Copy link
Copy Markdown
Member

alalek commented Apr 26, 2021

Thank you for contribution!

This patch should go into 3.4 branch first.
We will merge changes from 3.4 into master regularly (weekly/bi-weekly).

Please:

  • change "base" branch of this PR: master => 3.4 (use "Edit" button near PR title)
  • rebase your commits from master onto 3.4 branch. For example:
    git rebase -i --onto upstream/3.4 upstream/master
    (check list of your commits, save and quit (Esc + "wq" + Enter)
    where upstream is configured by following this GitHub guide and fetched (git fetch upstream).
  • push rebased commits into source branch of your fork (with --force option)

Note: no needs to re-open PR, apply changes "inplace".

@micha137 micha137 changed the base branch from master to 3.4 April 27, 2021 08:48
@micha137
Copy link
Copy Markdown
Contributor Author

micha137 commented Apr 27, 2021

@alalek Rebased it. Thank you for the detailed instructions!

@micha137
Copy link
Copy Markdown
Contributor Author

micha137 commented Apr 27, 2021

It doesn't look quite right... the rebase showed only my one commit, but github so many...

@micha137
Copy link
Copy Markdown
Contributor Author

micha137 commented Apr 27, 2021

Now it looks better.

@opencv-pushbot opencv-pushbot merged commit a08eac4 into opencv:3.4 Apr 27, 2021
@alalek alalek mentioned this pull request May 1, 2021
Merged
@alalek alalek mentioned this pull request Jun 4, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alalek alalek alalek approved these changes

Assignees

@alalek alalek

Labels

bug category: documentation Documentation fix or update

Projects

None yet

Milestone

3.4.15

Development

Successfully merging this pull request may close these issues.

3 participants

@micha137 @alalek @opencv-pushbot