Fix header sorting for modules without headers#19913
Merged
opencv-pushbot merged 1 commit intoopencv:3.4from Apr 15, 2021
Merged
Fix header sorting for modules without headers#19913opencv-pushbot merged 1 commit intoopencv:3.4from
opencv-pushbot merged 1 commit intoopencv:3.4from
Conversation
alalek
approved these changes
Apr 15, 2021
alalek
reviewed
Apr 15, 2021
Comment on lines
879
to
+882
| set(__module_headers ${OPENCV_MODULE_${the_module}_HEADERS}) | ||
| list(SORT __module_headers) # fix headers order, useful for bindings | ||
| if(__module_headers) | ||
| list(SORT __module_headers) # fix headers order, useful for bindings | ||
| endif() |
Member
There was a problem hiding this comment.
BTW, Looks like this problem is related to old CMake only (reproduced with CMake 2.8.12, CMake 3.18 is OK):
Alternative fix of this problem is adding quotes "" in the set() call:
set(__module_headers "${OPENCV_MODULE_${the_module}_HEADERS}")
list(SORT __module_headers)
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
related #19819
There can exist modules without headers causing configuration issue: