Skip to content

backport to 3.4 for supporting yolov4x-mish#19877

Closed
erikguo wants to merge 1 commit intoopencv:3.4from
erikguo:issue/19876/yolov4x-mish
Closed

backport to 3.4 for supporting yolov4x-mish#19877
erikguo wants to merge 1 commit intoopencv:3.4from
erikguo:issue/19876/yolov4x-mish

Conversation

@erikguo
Copy link
Copy Markdown

@erikguo erikguo commented Apr 8, 2021 •
edited by alalek
Loading

To fix for #19876

@asmorkalov

Details 
force_builders=Custom,Custom Win,Custom Mac
build_image:Custom=ubuntu-openvino-2021.2.0:20.04
build_image:Custom Win=openvino-2020.3.0
build_image:Custom Mac=openvino-2021.3.0

test_modules:Custom=dnn,python2,python3,java
test_modules:Custom Win=dnn,python2,python3,java
test_modules:Custom Mac=dnn,python2,python3,java

buildworker:Custom=linux-1
# disabled due high memory usage: test_opencl:Custom=ON
test_opencl:Custom=OFF
test_bigdata:Custom=1
test_filter:Custom=*

@arnaud-nt2i
Copy link
Copy Markdown

arnaud-nt2i commented Apr 15, 2021

@alalek @YashasSamaga @asmorkalov up for merging

@arnaud-nt2i
Copy link
Copy Markdown

arnaud-nt2i commented May 12, 2021

@alalek @YashasSamaga @asmorkalov @dkurt Why is merging is still blocked If all checks have passed ?

@alalek
Copy link
Copy Markdown
Member

alalek commented May 12, 2021

@arnaud-nt2i Please read the contribution guidelines first.

@arnaud-nt2i
Copy link
Copy Markdown

arnaud-nt2i commented May 12, 2021

@arnaud-nt2i Please read the contribution guidelines first.

I have read them and indeed, since all checks have passed, i'm confused about why no reviewers are assigned...

Sorry to sound pushy, I just wanted to make sure the subject wasn't buried

@alalek
Copy link
Copy Markdown
Member

alalek commented May 14, 2021

Checks passed because there are no checks for added functionality.
Reviewers should not accept changes of new functionality without the tests.
There is red label for this PR. I believe anyone can see that.

This PR is incomplete.

@arnaud-nt2i
Copy link
Copy Markdown

arnaud-nt2i commented May 18, 2021

Checks passed because there are no checks for added functionality.
Reviewers should not accept changes of new functionality without the tests.
There is red label for this PR. I believe anyone can see that.

This PR is incomplete.

ok thank you very much for your explanations

@asmorkalov
Copy link
Copy Markdown
Contributor

asmorkalov commented Jun 2, 2021

@erikguo Friendly reminder about tests.

@arnaud-nt2i arnaud-nt2i mentioned this pull request Jun 7, 2021
Closed
@asmorkalov
Copy link
Copy Markdown
Contributor

asmorkalov commented Jul 26, 2021

@erikguo Friendly reminder.

@asmorkalov asmorkalov requested a review from rogday September 3, 2021 07:33
@rogday rogday mentioned this pull request Sep 8, 2021
Merged
6 tasks
@rogday
Copy link
Copy Markdown
Member

rogday commented Sep 22, 2021

Replaced by #20671

@rogday rogday closed this Sep 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rogday rogday Awaiting requested review from rogday

Assignees

No one assigned

Labels

category: dnn feature pr: needs test New functionality requires minimal tests set

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@erikguo @arnaud-nt2i @alalek @asmorkalov @rogday