Fix Android NDK camera's color format conversions#19855
Merged
opencv-pushbot merged 2 commits intoopencv:masterfrom Apr 6, 2021
Merged
Fix Android NDK camera's color format conversions#19855opencv-pushbot merged 2 commits intoopencv:masterfrom
opencv-pushbot merged 2 commits intoopencv:masterfrom
Conversation
alalek
approved these changes
Apr 6, 2021
Member
alalek
left a comment
There was a problem hiding this comment.
Well done! Thank you 👍
BTW, Android Java camera code (JavaCameraView) provides "RGBA" frames (32-bit).
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Follow up to #19597 to address #19597 (comment)
Adds support for setting the color conversion with the CV_CAP_PROP_FOURCC property
Removes support for CAP_PROP_CONVERT_RGB property
Sample at https://github.com/komakai/NdkCamtest updated to use the FOURCC property
Based on feedback from @xhj14012 add logging to warn that setting exposure/ISO property has no effect unless AutoExposure is off