Add maxIters parameter to LMeDS method in findFundamentalMat#19854
Merged
opencv-pushbot merged 1 commit intoopencv:3.4from Apr 6, 2021
Merged
Add maxIters parameter to LMeDS method in findFundamentalMat#19854opencv-pushbot merged 1 commit intoopencv:3.4from
opencv-pushbot merged 1 commit intoopencv:3.4from
Conversation
This commit passes the parameter maxIters that represent the maximum number of iterations, that can be passed to findFundamentalMat to the method LMeDS. This parameter were added to the function findFundamentalMat and were passed just for the RANSAC method, but should be passed to both methods to be consistent.
Contributor
Author
|
@etrulls can you take a look at it and see if it makes sense? |
Contributor
|
Looks good to me, thanks for adding it. |
alalek
approved these changes
Apr 6, 2021
Member
alalek
left a comment
There was a problem hiding this comment.
@gasparitiago Thank you for the contribution!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit passes the parameter maxIters that represent
the maximum number of iterations, that can be passed to findFundamentalMat
to the method LMeDS.
This parameter were added to the function findFundamentalMat and
were passed just for the RANSAC method, but should be passed to
both methods to be consistent.
Related work: #16498
Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.