Skip to content

Expose maxIters in findEssentialMat#19847

Merged
opencv-pushbot merged 1 commit intoopencv:3.4from
gasparitiago:expose-max-iters
Apr 8, 2021
Merged

Expose maxIters in findEssentialMat#19847
opencv-pushbot merged 1 commit intoopencv:3.4from
gasparitiago:expose-max-iters

Conversation

@gasparitiago
Copy link
Copy Markdown
Contributor

@gasparitiago gasparitiago commented Apr 2, 2021 •
edited
Loading

Lets the user choose the maximum number of iterations the robust
estimator runs for, similary to findFundamentalMat
and findHomography functions.

Original issue: #19845
Related work: #16498

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or other license that is incompatible with OpenCV
  • The PR is proposed to proper branch
  • There is reference to original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@gasparitiago gasparitiago mentioned this pull request Apr 2, 2021
Closed
@gasparitiago gasparitiago marked this pull request as draft April 4, 2021 00:42
@gasparitiago gasparitiago force-pushed the expose-max-iters branch 2 times, most recently from 149357d to 9286798 Compare April 7, 2021 01:21
@gasparitiago
Expose maxIters in findEssentialMat
9f295b2 
Lets the user choose the maximum number of iterations the robust
estimator runs for, similary to findFundamentalMat
and findHomography functions.
@gasparitiago gasparitiago marked this pull request as ready for review April 7, 2021 11:08
alalek
alalek approved these changes Apr 7, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@alalek alalek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for contribution 👍

@opencv-pushbot opencv-pushbot merged commit be17fce into opencv:3.4 Apr 8, 2021
This was referenced Apr 8, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alalek alalek alalek approved these changes

Assignees

@alalek alalek

Labels

category: calib3d feature

Projects

None yet

Milestone

3.4.15

Development

Successfully merging this pull request may close these issues.

3 participants

@gasparitiago @alalek @opencv-pushbot