Skip to content

[G-API]: Fix kernel's input conversion bug#19815

Merged
opencv-pushbot merged 1 commit intoopencv:masterfrom
OrestChura:oc/fix_garray_garray_input
Mar 31, 2021
Merged

[G-API]: Fix kernel's input conversion bug#19815
opencv-pushbot merged 1 commit intoopencv:masterfrom
OrestChura:oc/fix_garray_garray_input

Conversation

@OrestChura
Copy link
Copy Markdown
Contributor

@OrestChura OrestChura commented Mar 31, 2021 •
edited by alalek
Loading

Fixes conversion of the kernel's input for GArray<GArray<U>> -> vector<vector<U>> case

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or other license that is incompatible with OpenCV
  • The PR is proposed to proper branch
  • There is reference to original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake
force_builders=Custom,Custom Win,Custom Mac
build_gapi_standalone:Linux x64=ade-0.1.1f
build_gapi_standalone:Win64=ade-0.1.1f
build_gapi_standalone:Mac=ade-0.1.1f
build_gapi_standalone:Linux x64 Debug=ade-0.1.1f

build_image:Custom=centos:7
buildworker:Custom=linux-1
build_gapi_standalone:Custom=ade-0.1.1f

Xbuild_image:Custom=ubuntu-openvino-2021.3.0:20.04
build_image:Custom Win=openvino-2021.2.0
build_image:Custom Mac=openvino-2021.2.0

test_modules:Custom=gapi,python2,python3,java
test_modules:Custom Win=gapi,python2,python3,java
test_modules:Custom Mac=gapi,python2,python3,java

buildworker:Custom=linux-1
# disabled due high memory usage: test_opencl:Custom=ON
Xtest_opencl:Custom=OFF
Xtest_bigdata:Custom=1
Xtest_filter:Custom=*

@OrestChura OrestChura added this to the 4.5.2 milestone Mar 31, 2021
@OrestChura OrestChura requested a review from dmatveev March 31, 2021 20:13
@dmatveev dmatveev self-assigned this Mar 31, 2021
dmatveev
dmatveev approved these changes Mar 31, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@dmatveev dmatveev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thanks a lot @OrestChura

@alalek this is that hotfix I mentioned.

@OrestChura OrestChura force-pushed the oc/fix_garray_garray_input branch from ef04588 to 921c455 Compare March 31, 2021 20:46
@dmatveev
Copy link
Copy Markdown
Contributor

dmatveev commented Mar 31, 2021

No idea but your branch builds fine for me locally. Python2 bindings are enabled.

  C/C++:
    Built as dynamic libs?:      YES
    C++ standard:                11
    C++ Compiler:                /usr/bin/c++  (ver 7.5.0)

@alalek
Copy link
Copy Markdown
Member

alalek commented Mar 31, 2021

Ignore compilation problems on Linux. They are not related to this patch and they are sporadic (something was merged earlier during the last 2 days).

@opencv-pushbot opencv-pushbot merged commit 7baae20 into opencv:master Mar 31, 2021
@dmatveev
Copy link
Copy Markdown
Contributor

dmatveev commented Apr 1, 2021

@alalek thanks, but I believe there is still a need in follow-up - some tests may be unstable

@TolyaTalamanov are you aware of any python changes causing the issue here?

@alalek alalek mentioned this pull request Apr 9, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dmatveev dmatveev dmatveev approved these changes

Assignees

@dmatveev dmatveev

Labels

bug category: g-api / gapi

Projects

None yet

Milestone

4.5.2

Development

Successfully merging this pull request may close these issues.

4 participants

@OrestChura @dmatveev @alalek @opencv-pushbot