Skip to content

Added reduce sum by channel support#19798

Merged
opencv-pushbot merged 1 commit intoopencv:3.4from
LupusSanctus:am/reduce_sum_ch
Mar 30, 2021
Merged

Added reduce sum by channel support#19798
opencv-pushbot merged 1 commit intoopencv:3.4from
LupusSanctus:am/reduce_sum_ch

Conversation

@LupusSanctus
Copy link
Copy Markdown

@LupusSanctus LupusSanctus commented Mar 28, 2021 •
edited
Loading

Merge with extra: opencv/opencv_extra#868
Fixes #19512: added TF sum reduction_indices=-1 case support

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or other license that is incompatible with OpenCV
  • The PR is proposed to proper branch
  • There is reference to original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake
force_builders=Custom,Custom Win,Custom Mac
build_image:Custom=ubuntu-openvino-2021.2.0:20.04
build_image:Custom Win=openvino-2021.1.0
build_image:Custom Mac=openvino-2021.2.0

test_modules:Custom=dnn,python2,python3,java
test_modules:Custom Win=dnn,python2,python3,java
test_modules:Custom Mac=dnn,python2,python3,java

buildworker:Custom=linux-1
# disabled due high memory usage: test_opencl:Custom=ON
test_opencl:Custom=OFF
test_bigdata:Custom=1
test_filter:Custom=*

allow_multiple_commits=1

@LupusSanctus LupusSanctus mentioned this pull request Mar 28, 2021
Merged
@LupusSanctus LupusSanctus requested a review from alalek March 28, 2021 13:59
@alalek
Copy link
Copy Markdown
Member

alalek commented Mar 30, 2021

Thank you!

This patch should go into 3.4 branch first.
We will merge changes from 3.4 into master regularly (weekly/bi-weekly).

Please:

  • change "base" branch of this PR: master => 3.4 (use "Edit" button near PR title)
  • rebase your commits from master onto 3.4 branch. For example:
    git rebase -i --onto upstream/3.4 upstream/master
    (check list of your commits, save and quit (Esc + "wq" + Enter)
    where upstream is configured by following this GitHub guide and fetched (git fetch upstream).
  • push rebased commits into source branch of your fork (with --force option)

Note: no needs to re-open PR, apply changes "inplace".

@LupusSanctus LupusSanctus changed the base branch from master to 3.4 March 30, 2021 20:07
@LupusSanctus
Copy link
Copy Markdown
Author

LupusSanctus commented Mar 30, 2021

@alalek, rebase was done.

alalek
alalek approved these changes Mar 30, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@alalek alalek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done! Thank you 👍

@opencv-pushbot opencv-pushbot merged commit 0dcb99c into opencv:3.4 Mar 30, 2021
@alalek alalek mentioned this pull request Apr 1, 2021
Merged
@alalek alalek mentioned this pull request Apr 9, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alalek alalek alalek approved these changes

Assignees

@alalek alalek

Labels

category: dnn feature

Projects

None yet

Milestone

3.4.14

Development

Successfully merging this pull request may close these issues.

Unsupported situations for loading "Sum" layer using readNetFromTensorflow

3 participants

@LupusSanctus @alalek @opencv-pushbot