Skip to content

Introduce relaxed accuracy thresholds for CL target in some dnn tests.#19774

Merged
opencv-pushbot merged 1 commit intoopencv:3.4from
aarongreig:aaron/dnn/oclTestAccuracyThresholds
Mar 25, 2021
Merged

Introduce relaxed accuracy thresholds for CL target in some dnn tests.#19774
opencv-pushbot merged 1 commit intoopencv:3.4from
aarongreig:aaron/dnn/oclTestAccuracyThresholds

Conversation

@aarongreig
Copy link
Copy Markdown
Contributor

Partially addresses #9821

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or other license that is incompatible with OpenCV
  • The PR is proposed to proper branch
  • There is reference to original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

Copy link
Copy Markdown
Member

@alalek alalek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for contribution!

It makes sense to put this patch to 3.4 branch first.
We will merge changes from 3.4 into master regularly (weekly/bi-weekly).

Please:

  • change "base" branch of this PR: master => 3.4 (use "Edit" button near PR title)
  • rebase your commits from master onto 3.4 branch. For example:
    git rebase -i --onto upstream/3.4 upstream/master
    (check list of your commits, save and quit (Esc + "wq" + Enter)
    where upstream is configured by following this GitHub guide and fetched (git fetch upstream).
  • push rebased commits into source branch of your fork (with --force option)

Note: no needs to re-open PR, apply changes "inplace".

@aarongreig aarongreig changed the base branch from master to 3.4 March 24, 2021 16:15
@aarongreig aarongreig force-pushed the aaron/dnn/oclTestAccuracyThresholds branch from b9a3845 to 9866e28 Compare March 24, 2021 16:15
@aarongreig aarongreig force-pushed the aaron/dnn/oclTestAccuracyThresholds branch from 9866e28 to f59917b Compare March 25, 2021 10:59
Copy link
Copy Markdown
Member

@alalek alalek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done! Thank you 👍

@opencv-pushbot opencv-pushbot merged commit 26ea476 into opencv:3.4 Mar 25, 2021
@alalek alalek mentioned this pull request Mar 27, 2021
@alalek alalek mentioned this pull request Apr 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants