[hal][neon] Optimise v_expand for AArch64#19773
Merged
opencv-pushbot merged 1 commit intoopencv:3.4from Mar 26, 2021
Merged
Conversation
Contributor
Author
|
@alalek I would like to add you as a reviewer, but I can't seem to sorry |
Contributor
Author
|
To benchmark this change, I ran a few perf tests which call ./opencv_perf_imgproc --gtest_filter=*cvtColor* --gtest_param_filter=*127*Luv*RG* --perf_min_samples=20 --perf_force_samples=20 --perf_write_validation_results=results.logon a c6gd.4xlarge instance, taking the average of 100 runs before and after the changes. As you can see below, I got a speed up of just under 1%.
|
alalek
approved these changes
Mar 26, 2021
Member
alalek
left a comment
There was a problem hiding this comment.
Looks good to me! Thank you for contribution 👍
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similar to #19486 we can fuse the two intrinsics
into the equivalent single intrinsic
for AArch64.
On gcc 10.2 and before, the compiler emits fewer instructions (see https://godbolt.org/z/x9GcY5evj).
Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.