Merged
Conversation
Member
|
@lionkunonly Thank you! @jlb6740 Could you please check this patch in your environment? |
|
Hi @alalek @lionkunonly, sorry only noticed this update here. Yes! I tried the patch and indeed it appears to resolve the issue. The steps I followed were: I also tested cvtColor.js which worked fine. |
Member
|
@jlb6740 Thank you for checking this! @lionkunonly Please:
Note: no needs to re-open PR, apply changes "inplace". |
Member
|
@lionkunonly I'm not able to update PR source branch because your fork is not forked from opencv/opencv repository: You can grab rebased commit from here: https://github.com/alalek/opencv/commits/pr19771_r |
alalek
approved these changes
Apr 1, 2021
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #19754
This is a Pull Request for the Issue 19754
For the perf tests in OpenCV.js, the scripts can not run successfully on Node.js. In this PR, I modify the scripts in perf tests so that the functions imported from other modules can run successfully in perf tests.
Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.