Skip to content

[G-API] Blocking dims order fix#19763

Merged
opencv-pushbot merged 1 commit intoopencv:masterfrom
TolyaTalamanov:at/blockingdesc-order-fix
Mar 23, 2021
Merged

[G-API] Blocking dims order fix#19763
opencv-pushbot merged 1 commit intoopencv:masterfrom
TolyaTalamanov:at/blockingdesc-order-fix

Conversation

@TolyaTalamanov
Copy link
Copy Markdown
Contributor

@TolyaTalamanov TolyaTalamanov commented Mar 22, 2021 •
edited by alalek
Loading

relates #19738

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or other license that is incompatible with OpenCV
  • The PR is proposed to proper branch
  • There is reference to original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

Build configuration

Xforce_builders_only=linux,docs
force_builders=Custom,Custom Win,Custom Mac
build_gapi_standalone:Linux x64=ade-0.1.1f
build_gapi_standalone:Win64=ade-0.1.1f
build_gapi_standalone:Mac=ade-0.1.1f
build_gapi_standalone:Linux x64 Debug=ade-0.1.1f

Xbuild_image:Custom=centos:7
Xbuildworker:Custom=linux-1
build_gapi_standalone:Custom=ade-0.1.1f

build_image:Custom=ubuntu-openvino-2021.1.0:20.04
build_image:Custom Win=openvino-2021.1.0
build_image:Custom Mac=openvino-2021.2.0

test_modules:Custom=gapi,python2,python3,java
test_modules:Custom Win=gapi,python2,python3,java
test_modules:Custom Mac=gapi,python2,python3,java

buildworker:Custom=linux-1
# disabled due high memory usage: test_opencl:Custom=ON
test_opencl:Custom=OFF
test_bigdata:Custom=1
test_filter:Custom=*

@TolyaTalamanov
Copy link
Copy Markdown
Contributor Author

TolyaTalamanov commented Mar 22, 2021

Fix for: #19738

TolyaTalamanov
TolyaTalamanov commented Mar 22, 2021
View reviewed changes
modules/gapi/src/backends/ie/giebackend.cpp

const size_t strideH = mat.step1();
IE::BlockingDesc bdesc({1, channels, height, width} /* dims */,
IE::BlockingDesc bdesc({1, height, width, channels} /* blocking dims */,
Copy link
Copy Markdown
Contributor Author

@TolyaTalamanov TolyaTalamanov Mar 22, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ilya-lavrenov I believe now it's ok

Copy link
Copy Markdown
Contributor Author

@TolyaTalamanov TolyaTalamanov Mar 22, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AsyaPronina FYI

@TolyaTalamanov
Copy link
Copy Markdown
Contributor Author

TolyaTalamanov commented Mar 22, 2021

@alalek

@opencv-pushbot opencv-pushbot merged commit a00d6b8 into opencv:master Mar 23, 2021
@alalek alalek mentioned this pull request Apr 9, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AsyaPronina AsyaPronina AsyaPronina approved these changes

+1 more reviewer

@ilya-lavrenov ilya-lavrenov ilya-lavrenov approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@AsyaPronina AsyaPronina

Labels

category: g-api / gapi

Projects

None yet

Milestone

4.5.2

Development

Successfully merging this pull request may close these issues.

5 participants

@TolyaTalamanov @ilya-lavrenov @AsyaPronina @opencv-pushbot @alalek