Skip to content

Implement Soft NMS#19748

Closed
WeiChungChang wants to merge 3 commits intoopencv:3.4from
WeiChungChang:soft_NMS
Closed

Implement Soft NMS#19748
WeiChungChang wants to merge 3 commits intoopencv:3.4from
WeiChungChang:soft_NMS

Conversation

@WeiChungChang
Copy link
Copy Markdown
Contributor

Implement Paper "Soft-NMS -- Improving Object Detection With One Line of Code"
https://arxiv.org/abs/1704.04503

It is the implementation part; will create sample program to RCNN models at the next step.

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or other license that is incompatible with OpenCV
  • The PR is proposed to proper branch
  • There is reference to original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@alalek
Copy link
Copy Markdown
Member

alalek commented Mar 27, 2021

@WeiChungChang Thank you for contribution!

Could you please to add in this PR:

  • public API in headers
  • documentation
  • simple tests for new functionality

@asenyaev
Copy link
Copy Markdown
Contributor

asenyaev commented Apr 8, 2021

jenkins cn please retry a build

@asmorkalov
Copy link
Copy Markdown
Contributor

@WeiChungChang friendly reminder.

@asmorkalov
Copy link
Copy Markdown
Contributor

@WeiChungChang friendly reminder about tests.

@asmorkalov
Copy link
Copy Markdown
Contributor

@WeiChungChang friendly reminder.

@asmorkalov asmorkalov requested a review from rogday September 30, 2021 08:23
@rogday rogday mentioned this pull request Oct 5, 2021
6 tasks
@rogday
Copy link
Copy Markdown
Member

rogday commented Oct 5, 2021

Replaced by #20813

@rogday rogday closed this Oct 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category: dnn feature incomplete pr: needs test New functionality requires minimal tests set

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants