fix camera_calibration sample for fisheye#19690
Merged
alalek merged 2 commits intoopencv:3.4from Mar 9, 2021
Merged
Conversation
Member
|
Thank you for contribution! As a "bugfix" this patch should go into 3.4 branch first. Please:
Note: no needs to re-open PR, apply changes "inplace". |
482fcd7 to
778bb98
Compare
Contributor
Author
|
sure, I've done so. |
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The camera_calibration sample has a bug where when using fisheye and with a video as the source, the corrected image is almost entirely empty except for the 1-4 pixels closest to the origin. This is because
fisheye::undistortImageuses an identity as the output camera matrix by default, and therefore maps all points very close to (0,0).This fix is to use
fisheye::estimateNewCameraMatrixForUndistortRectifyto create the output camera matrix, in the same manner that it is used when images are used as the calibration source.Also, there are two added guards around calibration flags for
calibrateCameraROthat are not applicable tofisheye::calibrate.relates #7040
Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.