Skip to content

add noexcept to default constructor for: Mat, UMat, Mat_, MatSize, MatStep#19683

Merged
opencv-pushbot merged 1 commit intoopencv:masterfrom
diablodale:add_defconstruct_noexcept_matumat
Mar 11, 2021
Merged

add noexcept to default constructor for: Mat, UMat, Mat_, MatSize, MatStep#19683
opencv-pushbot merged 1 commit intoopencv:masterfrom
diablodale:add_defconstruct_noexcept_matumat

Conversation

@diablodale
Copy link
Copy Markdown
Contributor

Resolves issue #19682

Pull Request Readiness Checklist

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or other license that is incompatible with OpenCV
  • The PR is proposed to proper branch
  • There is reference to original bug report and related work
  • The feature is well documented and sample code can be built with the project CMake

@diablodale
Copy link
Copy Markdown
Contributor Author

I'm seeing a lot of timeouts in Jenkins. Are there Jenkins problems occurring right now?

@asmorkalov
Copy link
Copy Markdown
Contributor

jenkins cn please retry a build

@diablodale
Copy link
Copy Markdown
Contributor Author

Thanks. Now I see only two failed tests within the "OpenCV CN Windows 10 x64".

videoio/videocapture_acceleration.read/61
videoio/videocapture_acceleration.read/63

These two tests are failing in others PRs like #19685.
I suspect these two test failures are not related to this PR and are instead an unrelated external error introduced.

@alalek
Copy link
Copy Markdown
Member

alalek commented Mar 7, 2021

Thank you for contribution! This is one more step in migration to proper usage of C++11.


This patch should go into 3.4 branch first.
We will merge changes from 3.4 into master regularly (weekly/bi-weekly).

Please:

  • change "base" branch of this PR: master => 3.4 (use "Edit" button near PR title)
  • rebase your commits from master onto 3.4 branch. For example:
    git rebase -i --onto upstream/3.4 upstream/master
    (check list of your commits, save and quit (Esc + "wq" + Enter)
    where upstream is configured by following this GitHub guide and fetched (git fetch upstream).
  • push rebased commits into source branch of your fork (with --force option)

Note: no needs to re-open PR, apply changes "inplace".


Ignore OpenCV CN checks. They are optional for now.

@diablodale
Copy link
Copy Markdown
Contributor Author

Ah, I wrote in the issue but not here...

As this is a new feature, not a bug fix, and requires C++11, this is for the 4.x branch of OpenCV.

@alalek
Copy link
Copy Markdown
Member

alalek commented Mar 11, 2021

OpenCV 3.4 is required to compile with C++98
There is no deny to compile/use OpenCV 3.4 with C++11/14/17

OpenCV 4.x just raises minimal supported compiler version (required version) from C++98 to C++11.

@diablodale
Copy link
Copy Markdown
Contributor Author

Got it. I'm focused on OpenCV 4.x and adding new features there. This is due to

  • The official statement from the OpenCV team when OpenCV 4.0 launched that the 3.x is in bugfix maintenance mode. https://opencv.org/opencv-4-0/
  • My own priorities. This PR is a new feature, not a bug fix. I architect, develop, and test new features for the OpenCV 4.x branch. Anyone that wants a new feature that I develop in open-source projects is welcome to take my code and re-write/backport it for something old. I am not part of that because I don't architect, develop, or test it for these old branches. New features....I only develop for current branches; not branches that are in bugfix maintenance mode.
  • I've been consistent with this in my contributions to OpenCV. I don't see this changing with new features.

Bugfixes are different. I might provide a bugfix that is for both 3.x and 4.x. I think I've only done that once for OpenCV -- it is rare. And that is the right approach as only important critical bugfixes should go to branches in bugfix maintenance mode.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category: core port/backport done Label for maintainers. Authors of PR can ignore this

Projects

None yet

Development

Successfully merging this pull request may close these issues.

add noexcept to default constructors: Mat, UMat, Mat_, MatSize, MatStep

4 participants