Skip to content

Removed unused variables found by pylint#19675

Merged
opencv-pushbot merged 1 commit intoopencv:3.4from
asmorkalov:as/pylint_warnings
Mar 9, 2021
Merged

Removed unused variables found by pylint#19675
opencv-pushbot merged 1 commit intoopencv:3.4from
asmorkalov:as/pylint_warnings

Conversation

@asmorkalov
Copy link
Copy Markdown
Contributor

@asmorkalov asmorkalov commented Mar 4, 2021 •
edited
Loading

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or other license that is incompatible with OpenCV
  • The PR is proposed to proper branch
  • There is reference to original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@alalek
Copy link
Copy Markdown
Member

alalek commented Mar 4, 2021 •
edited
Loading

Do you use check_pylint target?

@asmorkalov
Copy link
Copy Markdown
Contributor Author

asmorkalov commented Mar 4, 2021

Yes. The issues were found by modern version of pylint. Let me check the sample in details and i'll change the PR status.

@asmorkalov asmorkalov force-pushed the as/pylint_warnings branch from a1a93e4 to 6fe90b8 Compare March 5, 2021 15:09
@asmorkalov asmorkalov changed the base branch from master to 3.4 March 5, 2021 15:10
@asmorkalov asmorkalov changed the title WIP: Removed unused variables found by pylint Removed unused variables found by pylint Mar 5, 2021
@asmorkalov asmorkalov requested a review from alalek March 5, 2021 15:10
@alalek
Copy link
Copy Markdown
Member

alalek commented Mar 6, 2021

force-pushed the asmorkalov:as/pylint_warnings branch from a1a93e4 to 6fe90b8 yesterday
changed the base branch from master to 3.4 yesterday

This is wrong order of steps. Branch must be changed first to trigger proper builds at Buildbot (against the right target branch).

See here

alalek
alalek reviewed Mar 7, 2021
View reviewed changes
samples/dnn/virtual_try_on.py Outdated

def imaging_resample(self, img, xsize, ysize):
height, width, *args = img.shape
height, width = img.shape
Copy link
Copy Markdown
Member

@alalek alalek Mar 7, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

img.shape[0:2]?

Copy link
Copy Markdown
Contributor Author

@asmorkalov asmorkalov Mar 9, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

@asmorkalov asmorkalov force-pushed the as/pylint_warnings branch from 6fe90b8 to 4c48f1e Compare March 9, 2021 07:57
@asmorkalov asmorkalov requested a review from alalek March 9, 2021 07:57
@opencv-pushbot opencv-pushbot merged commit 6c9be1b into opencv:3.4 Mar 9, 2021
@alalek alalek mentioned this pull request Mar 13, 2021
Merged
@alalek alalek mentioned this pull request Apr 9, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alalek alalek alalek left review comments

@l-bat l-bat l-bat approved these changes

Assignees

@l-bat l-bat

Labels

category: python bindings category: samples

Projects

None yet

Milestone

3.4.14

Development

Successfully merging this pull request may close these issues.

4 participants

@asmorkalov @alalek @l-bat @opencv-pushbot