Conversation
|
Dear @alalek, could you please check Jenkins build and re-run this job? It fails with a git related issue: Thank you in advance. |
/cc @asmorkalov
@prittt You can ignore this for now because it is not related to this patch. |
|
@prittt Sorry for inconvenience, but Jenkins setup suffers from connectivity issues. We are working on the problem with local IT and hopefully it'll be fixed in mean time. Please ignore Jenkins CI status for now, it's optional. |
| // | ||
| // | ||
| // Intel License Agreement | ||
| // For Open Source Computer Vision Library |
There was a problem hiding this comment.
Please use short license header: https://github.com/opencv/opencv/wiki/Coding_Style_Guide#file-structure
// This file is part of OpenCV project.
// It is subject to the license terms in the LICENSE file found in the top-level directory
// of this distribution and at http://opencv.org/license.html.
//
// 2021 Federico Bolelli <federico.bolelli@unimore.it>
// 2021 Stefano Allegretti <stefano.allegretti@unimore.it>
// 2021 Costantino Grana <costantino.grana@unimore.it>
There was a problem hiding this comment.
@alalek, sorry I've missed it. Do you want me to replace also the connectedcomponents.cpp license header or just the ones in the hpp files?
There was a problem hiding this comment.
Lets update in new files only for now.
@asmorkalov no problem. Thank you for the fast answer. |
alalek
left a comment
There was a problem hiding this comment.
Great! Thank you for contribution 👍
This PR introduces optimization for
connectedComponents()andconnectedComponentsWithStats()functions by adding a new state-of-the-art CCL algorithm (i.e. Spaghetti Labeling) as described in Spaghetti Labeling: Directed Acyclic Graphs for Block-Based Connected Components Labeling, IEEE Transactions on Image Processing. Performance comparisons can be found in the paper and in the YACCLAB repository. Tests have been updated accordingly and additional test cases for statistics calculation have been added.Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.