Minor fixes to plugin compilation and VA feature#19610
Merged
opencv-pushbot merged 2 commits intoopencv:masterfrom Feb 24, 2021
Merged
Minor fixes to plugin compilation and VA feature#19610opencv-pushbot merged 2 commits intoopencv:masterfrom
opencv-pushbot merged 2 commits intoopencv:masterfrom
Conversation
alalek
reviewed
Feb 24, 2021
| VERIFY HAVE_LIBREALSENSE) | ||
| OCV_OPTION(WITH_VA "Include VA support" ON | ||
| VISIBLE_IF UNIX AND NOT ANDROID | ||
| OCV_OPTION(WITH_VA "Include VA support" (X86_64 OR X86) |
Member
There was a problem hiding this comment.
Why do we need to restrict this for x86 only?
Contributor
Author
There was a problem hiding this comment.
Although VA-API is not locked to this platform, I'm not aware of implementations on other platforms (see https://trac.ffmpeg.org/wiki/HWAccelIntro for example). Since we don't verify it we should disable it by default to avoid potential problems.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
related #19470 and #19562