Skip to content

Update python samples#19564

Merged
opencv-pushbot merged 1 commit intoopencv:3.4from
sturkmen72:patch-4
Feb 22, 2021
Merged

Update python samples#19564
opencv-pushbot merged 1 commit intoopencv:3.4from
sturkmen72:patch-4

Conversation

@sturkmen72
Copy link
Copy Markdown
Contributor

@sturkmen72 sturkmen72 commented Feb 18, 2021

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or other license that is incompatible with OpenCV
  • The PR is proposed to proper branch
  • There is reference to original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

alalek
alalek reviewed Feb 21, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@alalek alalek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for contribution!

samples/python/tutorial_code/videoio/video-input-psnr-ssim.py Outdated
captRefrnc = cv.VideoCapture(sourceReference)
captUndTst = cv.VideoCapture(sourceCompareWith)
captRefrnc = cv.VideoCapture(cv.samples.findFile(sourceReference))
captUndTst = cv.VideoCapture(cv.samples.findFile(sourceCompareWith))
Copy link
Copy Markdown
Member

@alalek alalek Feb 21, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use findFileOrKeep with VideoCapture.
Users may want to pass URI or GStreamer pipeline which are not handled by findFile() function.

alalek
alalek approved these changes Feb 22, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@alalek alalek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 👍

@opencv-pushbot opencv-pushbot merged commit 1de02b9 into opencv:3.4 Feb 22, 2021
@sturkmen72 sturkmen72 deleted the patch-4 branch February 22, 2021 20:12
@alalek alalek mentioned this pull request Feb 27, 2021
Merged
@alalek alalek mentioned this pull request Apr 9, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alalek alalek alalek approved these changes

Assignees

@alalek alalek

Labels

category: python bindings category: samples

Projects

None yet

Milestone

3.4.14

Development

Successfully merging this pull request may close these issues.

3 participants

@sturkmen72 @alalek @opencv-pushbot