different paddings in cvtColorTwoPlane() for biplane YUV420#19554
Merged
alalek merged 3 commits intoopencv:3.4from Sep 22, 2021
Merged
Conversation
amirtu
commented
Feb 18, 2021
Contributor
|
@amirtu There is failed test in CI log: |
asmorkalov
requested changes
Feb 19, 2021
amirtu
commented
Feb 19, 2021
alalek
reviewed
Feb 20, 2021
asmorkalov
reviewed
Feb 20, 2021
amirtu
commented
Feb 24, 2021
| { | ||
| CV_INSTRUMENT_REGION(); | ||
|
|
||
| const uchar* uv = src_data + src_step * static_cast<size_t>(dst_height); |
Member
Author
There was a problem hiding this comment.
Is the pointer arithmetics being done under dispatched branch of code by purpose?
alalek
reviewed
Feb 25, 2021
0c861d8 to
e6f2066
Compare
Contributor
|
jenkins cn please retry a build |
e6f2066 to
e84fb22
Compare
asmorkalov
approved these changes
Sep 22, 2021
Contributor
|
@alalek I fixed build issue for dispatch case and rebased the branch to current 3.4. Please take a look and merge the PR. |
alalek
reviewed
Sep 22, 2021
Comment on lines
+149
to
+152
| CALL_HAL(cvtTwoPlaneYUVtoBGREx, cv_hal_cvtTwoPlaneYUVtoBGREx, | ||
| y_data, y_step, uv_data, uv_step, dst_data, dst_step, dst_width, dst_height, dcn, swapBlue, uIdx); | ||
|
|
||
| CV_CPU_DISPATCH(cvtTwoPlaneYUVtoBGR, (y_data, y_step, uv_data, uv_step, dst_data, dst_step, dst_width, dst_height, dcn, swapBlue, uIdx), |
Member
There was a problem hiding this comment.
We should have fallback on HAL code specialized for y_step == uv_step case.
Otherwise this patch introduces performance regressions (to see that, drop changes from the HAL implementations).
if (y_step == uv_step)
CALL_HAL(cvtTwoPlaneYUVtoBGR, cv_hal_cvtTwoPlaneYUVtoBGR, ...)
See discussion near removed CV_CheckEQ() for details (which is not resolved).
Merged
Merged
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #17036
Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.