getDefaultName() isn't overloaded in SparseOpticalFlow#19532
Merged
opencv-pushbot merged 1 commit intoopencv:3.4from Feb 15, 2021
Merged
getDefaultName() isn't overloaded in SparseOpticalFlow#19532opencv-pushbot merged 1 commit intoopencv:3.4from
opencv-pushbot merged 1 commit intoopencv:3.4from
Conversation
3 tasks
Contributor
|
The same issue is valid for dense optical flow like TVL1. Please check other children of cv::Algorithm in video module and add the method there. |
asmorkalov
approved these changes
Feb 15, 2021
Contributor
asmorkalov
left a comment
There was a problem hiding this comment.
God job! Please squach commits and the patch can be merged.
4c22122 to
cbb230f
Compare
Contributor
|
@alalek I think we can merge it. |
This was referenced Feb 21, 2021
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #17960
Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.