Reduce if statement as it has the same expression on both sides of '&&'#19525
Merged
alalek merged 2 commits intoopencv:3.4from Feb 15, 2021
Merged
Reduce if statement as it has the same expression on both sides of '&&'#19525alalek merged 2 commits intoopencv:3.4from
alalek merged 2 commits intoopencv:3.4from
Conversation
Contributor
Author
asmorkalov
requested changes
Feb 15, 2021
Contributor
asmorkalov
left a comment
There was a problem hiding this comment.
Thanks for the contribution! The same bug exists in branch 3.4 too. This patch should go into 3.4 branch first. We will merge changes from 3.4 into master regularly (weekly/bi-weekly).
So, please:
- change "base" branch of this PR: master => 3.4 (use "Edit" button near PR title)
- rebase your commits from master onto 3.4 branch. For example:
git rebase -i --onto upstream/3.4 upstream/master
(check list of your commits, save and quit (Esc + "wq" + Enter)
whereupstreamis configured by following this GitHub guide and fetched (git fetch upstream). - push rebased commits into source branch of your fork (with
--forceoption)
Note: no need to re-open PR, apply changes "inplace".
If statement has the same expression on both sides so this can be reduce Signed-off-by: Dan Ben Yosef <danbey@gmail.com>
eec6482 to
d26466f
Compare
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If statement has the same expression on both sides so this can be reduce
Signed-off-by: Dan Ben Yosef danbey@gmail.com
Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.