Skip to content

Refine the execution order of for loop#19520

Merged
opencv-pushbot merged 1 commit intoopencv:3.4from
WeiChungChang:refine
Feb 13, 2021
Merged

Refine the execution order of for loop#19520
opencv-pushbot merged 1 commit intoopencv:3.4from
WeiChungChang:refine

Conversation

@WeiChungChang
Copy link
Copy Markdown
Contributor

As the source code, since width and height do NOT depend on variable within the inner loop, it is better to move them to the first loop and we can save several redundant executions.

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • [v] I agree to contribute to the project under Apache 2 License.
  • [v] To the best of my knowledge, the proposed patch is not based on a code under GPL or other license that is incompatible with OpenCV
  • [v] The PR is proposed to proper branch
  • There is reference to original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

Copy link
Copy Markdown
Member

@alalek alalek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for contribution 👍

@opencv-pushbot opencv-pushbot merged commit cceec84 into opencv:3.4 Feb 13, 2021
@alalek alalek mentioned this pull request Feb 21, 2021
@alalek alalek mentioned this pull request Apr 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants