Skip to content

goodFeaturesToTrack returns also corners quality#19511

Closed
amirtu wants to merge 7 commits intoopencv:3.4from
amirtu:OCV-165_finalize_goodFeaturesToTrack_returns_also_corner_value_PR_3
Closed

goodFeaturesToTrack returns also corners quality#19511
amirtu wants to merge 7 commits intoopencv:3.4from
amirtu:OCV-165_finalize_goodFeaturesToTrack_returns_also_corner_value_PR_3

Conversation

@amirtu
Copy link
Copy Markdown
Member

@amirtu amirtu commented Feb 12, 2021

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or other license that is incompatible with OpenCV
  • The PR is proposed to proper branch
  • There is reference to original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

WisdomPill and others added 7 commits February 12, 2021 12:49
@WisdomPill
goodFeaturesToTrack returns also corner value
57ca71b 
(cherry picked from commit 4a8f067)
@WisdomPill
Added response to GFTT Detector keypoints
b060f00 
(cherry picked from commit b88fb40)
@WisdomPill
Moved corner values to another optional variable to preserve backward…
d741d65 
… compatibility

(cherry picked from commit 6137383)
@WisdomPill
Removed corners valus from perf tests and better unit tests for corne…
a73be28 
…rs values

(cherry picked from commit f3d0ef2)
@WisdomPill
Fixed detector gftt call
736c46d 
(cherry picked from commit be29755)
@WisdomPill
Restored test_cornerEigenValsVecs
f2d58c5 
(cherry picked from commit ea3e118)
scaling fixed;
cbe4f97 
mineigen calculation rolled back;
gftt function overload added (with quality parameter);
perf tests were added for the new api function;
external bindings were added for the function (with different alias);
fixed issues with composition of the output array of the new function (e.g. as requested in comments) ;
added sanity checks in the perf tests;
removed C API changes.
@amirtu amirtu changed the title Ocv 165 finalize good features to track returns also corner value pr 3 goodFeaturesToTrack returns also corners quality Feb 12, 2021
@amirtu amirtu mentioned this pull request Feb 12, 2021
Merged
6 tasks
@amirtu
Copy link
Copy Markdown
Member Author

amirtu commented Feb 12, 2021

To be merged with opencv/opencv_extra#851

@amirtu amirtu closed this Feb 12, 2021
@amirtu amirtu deleted the OCV-165_finalize_goodFeaturesToTrack_returns_also_corner_value_PR_3 branch February 12, 2021 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@amirtu @WisdomPill