Skip to content

CHange import order to avoid apple check error#19468

Merged
opencv-pushbot merged 1 commit intoopencv:masterfrom
hmaarrfk:fix_apple_check
Feb 6, 2021
Merged

CHange import order to avoid apple check error#19468
opencv-pushbot merged 1 commit intoopencv:masterfrom
hmaarrfk:fix_apple_check

Conversation

@hmaarrfk
Copy link
Copy Markdown
Contributor

@hmaarrfk hmaarrfk commented Feb 6, 2021 •
edited
Loading

This fixes compilation errors with certain versions of OSX where one would obtain errors like:

In file included from ../modules/imgcodecs/src/apple_conversions.mm:5:
In file included from ../modules/imgcodecs/src/apple_conversions.h:8:
In file included from ../modules/core/include/opencv2/core.hpp:3304:
../modules/core/include/opencv2/core/utility.hpp:53:4: warning: Detected Apple 'check' macro definition, it can cause build conflicts. Please, include this header before any Apple headers. [-W#warnings]
#  warning Detected Apple 'check' macro definition, it can cause build conflicts. Please, include this header before any Apple headers.
   ^
../modules/core/include/opencv2/core/utility.hpp:905:5: warning: declaration does not declare anything [-Wmissing-declarations]
    bool check() const;
    ^~~~~~~~~~~~~~~~~~
3 warnings and 3 errors generated.

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or other license that is incompatible with OpenCV
  • The PR is proposed to proper branch
  • There is reference to original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@alalek
Copy link
Copy Markdown
Member

alalek commented Feb 6, 2021

Please add into description which kind of message is observed.
At least it would be useful for others who catch similar problem and use searching.

@hmaarrfk
Copy link
Copy Markdown
Contributor Author

hmaarrfk commented Feb 6, 2021

of course, sorry. let me find a recent log.

@hmaarrfk
Copy link
Copy Markdown
Contributor Author

hmaarrfk commented Feb 6, 2021

Do you also want a note in a changelog?

@alalek
Copy link
Copy Markdown
Member

alalek commented Feb 6, 2021

The message is enough. Thank you!

@opencv-pushbot opencv-pushbot merged commit 0c31c07 into opencv:master Feb 6, 2021
@alalek alalek mentioned this pull request Apr 9, 2021
Merged
@alalek alalek mentioned this pull request Jul 18, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alalek alalek alalek approved these changes

Assignees

@alalek alalek

Labels

category: build/install platform: ios/osx

Projects

None yet

Milestone

4.5.2

Development

Successfully merging this pull request may close these issues.

3 participants

@hmaarrfk @alalek @opencv-pushbot