Skip to content

Fix error in documentation for RGB->HSV convertion#19419

Merged
alalek merged 2 commits intoopencv:3.4from
Liangda-w:patch-1
Feb 1, 2021
Merged

Fix error in documentation for RGB->HSV convertion#19419
alalek merged 2 commits intoopencv:3.4from
Liangda-w:patch-1

Conversation

@Liangda-w
Copy link
Copy Markdown
Contributor

@Liangda-w Liangda-w commented Jan 28, 2021 •
edited by asmorkalov
Loading

Pull Request Readiness Checklist

Resolves #19406

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or other license that is incompatible with OpenCV
  • The PR is proposed to proper branch
  • There is reference to original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@Liangda-w
Copy link
Copy Markdown
Contributor Author

Liangda-w commented Jan 28, 2021

#19406

@asmorkalov
Copy link
Copy Markdown
Contributor

asmorkalov commented Jan 29, 2021 •
edited by alalek
Loading

@Liangda-w Please pay attention that you modifies RGB ↔ HLS documentation. It's ok, but the ticket says about RGB ↔ HSV. Please add the same to previous section too. Documentation preview for your PR: http://pullrequest.opencv.org/buildbot/export/pr/19419/docs/de/d25/imgproc_color_conversions.html

@asmorkalov asmorkalov added the category: documentation Documentation fix or update label Jan 29, 2021
@asmorkalov asmorkalov self-requested a review January 29, 2021 07:49
@vpisarev
Copy link
Copy Markdown
Contributor

vpisarev commented Jan 29, 2021

I can confirm that if R=G=B then H=S=0. @Liangda-w, please, update both RGB <=> HSV and RGB <=> HSL documentation, as @asmorkalov suggested, then your patch will be merged.

@Liangda-w
Copy link
Copy Markdown
Contributor Author

Liangda-w commented Jan 29, 2021

Thanks for pointing it out! :) @asmorkalov @vpisarev

@asmorkalov
Copy link
Copy Markdown
Contributor

asmorkalov commented Feb 1, 2021

Rendered documentation page: https://pullrequest.opencv.org/buildbot/export/pr/19419/docs/de/d25/imgproc_color_conversions.html

asmorkalov
asmorkalov approved these changes Feb 1, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@asmorkalov asmorkalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well Done! 👍
Please squash commits to have clear Git history in core repository after merge.

@alalek alalek merged commit b08d67c into opencv:3.4 Feb 1, 2021
@alalek alalek mentioned this pull request Feb 5, 2021
Merged
@alalek alalek mentioned this pull request Apr 9, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@asmorkalov asmorkalov asmorkalov approved these changes

Assignees

@asmorkalov asmorkalov

Labels

category: documentation Documentation fix or update

Projects

None yet

Milestone

3.4.14

Development

Successfully merging this pull request may close these issues.

4 participants

@Liangda-w @asmorkalov @vpisarev @alalek