highgui: expose VSYNC window property for OpenGL on W32#19408
Merged
opencv-pushbot merged 1 commit intoopencv:masterfrom Feb 3, 2021
Merged
highgui: expose VSYNC window property for OpenGL on W32#19408opencv-pushbot merged 1 commit intoopencv:masterfrom
opencv-pushbot merged 1 commit intoopencv:masterfrom
Conversation
1237f3d to
2707337
Compare
Contributor
Author
|
I believe the "OpenCV CN Windows 10 x64" build fails due to some error in the CI. it can't check out from the repo. |
Contributor
|
@crackwitz Windows 10 x64 fails due to infrastructure issue. I'm working on the problem right now. Please ignore the failed build for now. |
asmorkalov
requested changes
Feb 2, 2021
asmorkalov
approved these changes
Feb 3, 2021
Contributor
asmorkalov
left a comment
There was a problem hiding this comment.
Well done! 👍 Please squash commits to have clear git history after merge.
property getter/setter code conditional on HAVE_OPENGL getter: return -1 upon specific OpenGL errors
4a0bc10 to
ab0e1c5
Compare
Contributor
Author
|
squashed. |
This was referenced Apr 7, 2021
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
combined with the proposed zero-delay
pollKeyalternative to waitKey (separate pull request), disabling VSYNC can drastically speed up display of images. I can get close to 1000 fps for a trivial example (see below), whereas with VSYNC it's nailed to 60 fps (for my screen) and with mandatorySleep()inwaitKeyit's throttled to a jittery 100 FPS depending on OS scheduler.I hope I based this on the right branch. it's not a bug fix.I think I managed to retarget this to the master branch.I took the implementation of the TOPMOST property as a template and tried to emulate the code structure.
please let me know if I can improve or if this isn't the right way to get such code introduced.
Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.