Skip to content

fix peaky test failure#19390

Merged
opencv-pushbot merged 1 commit intoopencv:3.4from
tomoaki0705:fixCudaLegacyCalib3d
Jan 25, 2021
Merged

fix peaky test failure#19390
opencv-pushbot merged 1 commit intoopencv:3.4from
tomoaki0705:fixCudaLegacyCalib3d

Conversation

@tomoaki0705
Copy link
Copy Markdown
Contributor

@tomoaki0705 tomoaki0705 commented Jan 24, 2021 •
edited by alalek
Loading

closes #19389

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or other license that is incompatible with OpenCV
  • The PR is proposed to proper branch
  • There is reference to original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake
force_builders=Custom
buildworker:Custom=linux-4
build_image:Custom=ubuntu-cuda:18.04

alalek
alalek reviewed Jan 25, 2021
View reviewed changes
modules/cudalegacy/test/test_calib3d.cpp Outdated

ASSERT_LE(cv::norm(rvec - rvec_gold), 1e-3);
ASSERT_LE(cv::norm(tvec - tvec_gold), 1e-3);
ASSERT_LE(cv::norm(tvec - tvec_gold)/cv::norm(tvec_gold), 1e-3);
Copy link
Copy Markdown
Member

@alalek alalek Jan 25, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cv::norm(tvec - tvec_gold)/cv::norm(tvec_gold)

cv::norm(tvec, tvec_gold, NORM_L2 | NORM_RELATIVE);

Docs: https://docs.opencv.org/3.4/d2/de8/group__core__array.html#gad12cefbcb5291cf958a85b4b67b6149f

@tomoaki0705
fix peaky test failure
96e0902 
  * follow the review comment
@opencv-pushbot opencv-pushbot merged commit b1ffe7a into opencv:3.4 Jan 25, 2021
@tomoaki0705 tomoaki0705 deleted the fixCudaLegacyCalib3d branch January 25, 2021 13:43
This was referenced Jan 25, 2021
Merged
Merged
@alalek alalek mentioned this pull request Apr 9, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alalek alalek alalek approved these changes

Assignees

@alalek alalek

Labels

category: gpu/cuda (contrib) OpenCV 4.0+: moved to opencv_contrib test

Projects

None yet

Milestone

3.4.14

Development

Successfully merging this pull request may close these issues.

3 participants

@tomoaki0705 @alalek @opencv-pushbot