Common fixed size Python sequence conversion to OpenCV types#19344
Merged
opencv-pushbot merged 1 commit intoopencv:3.4from Jan 25, 2021
Merged
Conversation
4a069e7 to
cb6ad05
Compare
alalek
reviewed
Jan 21, 2021
Comment on lines
-1253
to
-1258
| if(PyComplex_Check(obj)) | ||
| { | ||
| p.x = PyComplex_RealAsDouble(obj); | ||
| p.y = PyComplex_ImagAsDouble(obj); | ||
| return true; | ||
| } |
Member
alalek
approved these changes
Jan 24, 2021
modules/python/test/test_misc.py
Outdated
| Rect = namedtuple('Rect', ('x', 'y', 'w', 'h')) | ||
| try_to_convert = partial(self._try_to_convert, cv.utils.dumpRect) | ||
| for convertible in ((1, 2, 4, 5), [5, 3, 10, 20], np.array([10, 20, 23, 10]), | ||
| Rect(10, 30, 40, 55)): |
Member
There was a problem hiding this comment.
Please add test cases which are used here:
np.array([10, 20, 23, 10]),
tuple(np.array([10, 20, 24, 10])),
list(np.array([10, 20, 25, 10])),
cb6ad05 to
1d3207d
Compare
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces common way on how fixed size sequence can be converted to OpenCV type e.g.
tuple/list/np.arraytocv::Rect.Each field of the OpenCV
structs are packed to lightweight reference wrappers array, so only homogeneous sequence can be parsed, soTermCriteriais parsed separately.This patch disables the conversion from Python complex to
cv::Point, because in my opinion it is error prone and doesn't take into account conversion from floating point values to integers as others do.Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.