Skip to content

docs: hotfix: call isOpened() in python bg sub tutorial#19300

Merged
opencv-pushbot merged 1 commit intoopencv:3.4from
alkasm:patch-2
Jan 12, 2021
Merged

docs: hotfix: call isOpened() in python bg sub tutorial#19300
opencv-pushbot merged 1 commit intoopencv:3.4from
alkasm:patch-2

Conversation

@alkasm
Copy link
Copy Markdown
Contributor

@alkasm alkasm commented Jan 9, 2021 •
edited
Loading

#19299

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or other license that is incompatible with OpenCV
  • The PR is proposed to proper branch
  • There is reference to original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@alkasm alkasm changed the title hotfix: call isOpened() in python bg sub tutorial docs: hotfix: call isOpened() in python bg sub tutorial Jan 9, 2021
@asmorkalov asmorkalov self-assigned this Jan 11, 2021
@asmorkalov asmorkalov self-requested a review January 11, 2021 12:06
asmorkalov
asmorkalov approved these changes Jan 11, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@asmorkalov asmorkalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@asmorkalov asmorkalov self-requested a review January 11, 2021 12:07
@asmorkalov
Copy link
Copy Markdown
Contributor

asmorkalov commented Jan 11, 2021

@alkasm Thanks for the patch. The same issue exists in branch 3.4. Please re-base your patch on top of 3.4 and re-target the PR to 3.4. OpenCV team merges 3.4 to master weekly or biweekly and the fix will be applied everywhere.

So, please:

  • change "base" branch of this PR: master => 3.4 (use "Edit" button near PR title)
  • rebase your commits from master onto 3.4 branch. For example:
    git rebase -i --onto upstream/3.4 upstream/master
    (check list of your commits, save and quit (Esc + "wq" + Enter)
    where upstream is configured by following this GitHub guide and fetched (git fetch upstream).
  • push rebased commits into source branch of your fork (with --force option)

Note: no need to re-open PR, apply changes "inplace".

@asmorkalov asmorkalov added the pr: needs rebase Rebase patch (and squash fixup commits) on the top of target branch label Jan 11, 2021
@alkasm alkasm changed the base branch from master to 3.4 January 11, 2021 21:51
@alkasm alkasm force-pushed the patch-2 branch 2 times, most recently from 941a979 to e3856df Compare January 11, 2021 22:06
@alkasm
Copy link
Copy Markdown
Contributor Author

alkasm commented Jan 11, 2021

No problem, rebased on top of 3.4.

asmorkalov
asmorkalov approved these changes Jan 12, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@asmorkalov asmorkalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@asmorkalov asmorkalov removed the pr: needs rebase Rebase patch (and squash fixup commits) on the top of target branch label Jan 12, 2021
@opencv-pushbot opencv-pushbot merged commit fbcc532 into opencv:3.4 Jan 12, 2021
@alalek alalek mentioned this pull request Jan 12, 2021
Merged
@alalek alalek mentioned this pull request Apr 9, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@asmorkalov asmorkalov asmorkalov approved these changes

Assignees

@asmorkalov asmorkalov

Labels

category: samples

Projects

None yet

Milestone

3.4.14

Development

Successfully merging this pull request may close these issues.

Background subtractor python tutorial does not call isOpened() method

4 participants

@alkasm @asmorkalov @opencv-pushbot @alalek