Skip to content

Template Matching Tutorial issue fix https://github.com/opencv/opencv…#19297

Merged
opencv-pushbot merged 1 commit intoopencv:3.4from
raaldrid:Template_Match_Tutorial_fix_17739
Jan 11, 2021
Merged

Template Matching Tutorial issue fix https://github.com/opencv/opencv…#19297
opencv-pushbot merged 1 commit intoopencv:3.4from
raaldrid:Template_Match_Tutorial_fix_17739

Conversation

@raaldrid
Copy link
Copy Markdown
Contributor

@raaldrid raaldrid commented Jan 8, 2021

Fix for Template Matching Tutorial issue 17739

Canvas and template images now update correctly in template matching tutorial

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or other license that is incompatible with OpenCV
  • The PR is proposed to proper branch
  • There is reference to original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake
build_image:Docs=docs-js

Copy link
Copy Markdown
Member

@alalek alalek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for contribution!

@@ -1,4 +1,4 @@
<!DOCTYPE html>
<!DOCTYPE html>
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to put BOM header here.
Remove this change from the patch.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. Commits squashed.

@raaldrid raaldrid force-pushed the Template_Match_Tutorial_fix_17739 branch from 3fd7c7b to 380009a Compare January 11, 2021 19:20
Copy link
Copy Markdown
Member

@alalek alalek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@opencv-pushbot opencv-pushbot merged commit 89ef676 into opencv:3.4 Jan 11, 2021
@alalek alalek mentioned this pull request Jan 12, 2021
@alalek alalek mentioned this pull request Apr 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants