Skip to content

docs(tutorial_js_usage): fix imshow usage#19291

Merged
opencv-pushbot merged 1 commit intoopencv:3.4from
gpiffault:docs-js_usage-fix_imshow
Jan 11, 2021
Merged

docs(tutorial_js_usage): fix imshow usage#19291
opencv-pushbot merged 1 commit intoopencv:3.4from
gpiffault:docs-js_usage-fix_imshow

Conversation

@gpiffault
Copy link
Copy Markdown
Contributor

@gpiffault gpiffault commented Jan 8, 2021

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or other license that is incompatible with OpenCV
  • The PR is proposed to proper branch
  • There is reference to original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@alalek
Copy link
Copy Markdown
Member

alalek commented Jan 9, 2021

Thank you for contribution!

As a "bugfix" this patch should go into 3.4 branch first.
We will merge changes from 3.4 into master regularly (weekly/bi-weekly).

Please:

  • change "base" branch of this PR: master => 3.4 (use "Edit" button near PR title)
  • rebase your commits from master onto 3.4 branch. For example:
    git rebase -i --onto upstream/3.4 upstream/master
    (check list of your commits, save and quit (Esc + "wq" + Enter)
    where upstream is configured by following this GitHub guide and fetched (git fetch upstream).
  • push rebased commits into source branch of your fork (with --force option)

Note: no needs to re-open PR, apply changes "inplace".

@gpiffault gpiffault changed the base branch from master to 3.4 January 9, 2021 13:51
@gpiffault gpiffault force-pushed the docs-js_usage-fix_imshow branch from 3be1791 to 0043d9b Compare January 9, 2021 13:55
@gpiffault
Copy link
Copy Markdown
Contributor Author

gpiffault commented Jan 9, 2021

Rebase done @alalek

@opencv-pushbot opencv-pushbot merged commit 5389309 into opencv:3.4 Jan 11, 2021
@alalek alalek mentioned this pull request Jan 12, 2021
Merged
@alalek alalek mentioned this pull request Apr 9, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alalek alalek alalek approved these changes

Assignees

@alalek alalek

Labels

bug category: documentation Documentation fix or update category: javascript (js)

Projects

None yet

Milestone

3.4.14

Development

Successfully merging this pull request may close these issues.

3 participants

@gpiffault @alalek @opencv-pushbot