support yolov4x-mish new_coords = 1 in both CPU and CUDA mode#19221
Closed
erikguo wants to merge 2 commits intoopencv:masterfrom
erikguo:issue/18975/yolov4x-mish
Closed
support yolov4x-mish new_coords = 1 in both CPU and CUDA mode#19221erikguo wants to merge 2 commits intoopencv:masterfrom erikguo:issue/18975/yolov4x-mish
erikguo wants to merge 2 commits intoopencv:masterfrom
erikguo:issue/18975/yolov4x-mish
Conversation
modules/dnn/src/cuda/region.cu
Outdated
| const auto y = (box_index % batch_inner_size) / row_inner_size; | ||
| const auto x = (box_index % row_inner_size) / col_inner_size; | ||
|
|
||
| const auto tmp_x = ((input[box_offset + 0]) - static_cast<T>(0.5)) * scale_x_y + static_cast<T>(0.5); |
Contributor
There was a problem hiding this comment.
I think the CPU code would have to go to 3.4. I am not sure what the maintainers will suggest you to do but here is a comment for the CUDA part.
Duplicating the whole kernel code for changing just two lines is overkill. Can you please add a function parameter instead?
Author
There was a problem hiding this comment.
Modified code to use a parameter in the function.
Contributor
There was a problem hiding this comment.
@YashasSamaga is right. Could you, please split the patch on 2 parts:
- CPU version for 3.4. We merge 3.4 to master weekly or biweekly and the solution appears in master too.
- CUDA version for master only. When the first patch is ready.
Contributor
There was a problem hiding this comment.
I propose to not close the PR, but create new one for 3.4 first.
Contributor
|
@erikguo Friendly reminder. |
|
@erikguo up |
Author
|
already create another pull request for version 3.4 @asmorkalov |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To fix for #18975
Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.