Merged
Conversation
alalek
approved these changes
Dec 24, 2020
Member
There was a problem hiding this comment.
Overall looks good to me.
Please note, that legacy C-API has zero test coverage, so we are not able to test this code. Also this is why regression in this function appears here (and lives here for 2+ years).
P.S. There are some C API tests are on 2.4 branch (EOL).
This was referenced Dec 24, 2020
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, OpenCV Team
This PR tries to fix #12818 on branch 3.4.
Though labled as
won't fixin existing issues, there are still some programs usingcvSaveImage( ). I just happen to migrate a project with many OpenCV C API calls to C++ API calls, comparing two implementations results, and encounter opencv 3.4 latest version (3.4.13)'scvSaveImage( )still crash on Windows platform. Thus I would like to share my solution.Pull Request Readiness Checklist
Patch to opencv_extra has the same branch name.
Apart from this PR's fix method, people could also write a simple function as alternative to the bug
cvSaveImage: