Find only linkable IE libraries, not plugins#19199
Merged
opencv-pushbot merged 1 commit intoopencv:masterfrom Dec 23, 2020
Merged
Find only linkable IE libraries, not plugins#19199opencv-pushbot merged 1 commit intoopencv:masterfrom
opencv-pushbot merged 1 commit intoopencv:masterfrom
Conversation
alalek
reviewed
Dec 22, 2020
Member
alalek
left a comment
There was a problem hiding this comment.
This change doesn't look right.
Can we finally use find_package(InferenceEngine) + find_package(ngraph) instead of these hacks? (and remove these hacks completely)
What is still missing to support that?
alalek
reviewed
Dec 22, 2020
d2f4a29 to
3ed376d
Compare
Contributor
Author
I suppose need to add a version to CC @asuhov can we update CI variables to use find package? |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this change some libraries like
inference_engine_ir_readerbecome plugins and MUST NOT be found by OpenCV cmake since OpenCV tries to link them toopencv_dnn, while plugins (.soon OSX) cannot be linked to other targets.