Skip to content

added the credits & copyrights of ISCAS#19082

Merged
opencv-pushbot merged 1 commit intoopencv:masterfrom
vpisarev:rvv_copyright
Dec 17, 2020
Merged

added the credits & copyrights of ISCAS#19082
opencv-pushbot merged 1 commit intoopencv:masterfrom
vpisarev:rvv_copyright

Conversation

@vpisarev
Copy link
Copy Markdown
Contributor

@vpisarev vpisarev commented Dec 11, 2020 •
edited
Loading

small but important addition to #18228

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or other license that is incompatible with OpenCV
  • The PR is proposed to proper branch
  • There is reference to original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@vpisarev
Copy link
Copy Markdown
Contributor Author

vpisarev commented Dec 11, 2020

Please, don't merge it yet. The exact wording is being clarified

@joy2myself
Copy link
Copy Markdown
Contributor

joy2myself commented Dec 14, 2020

Hi @vpisarev ,
I am not sure why we need to add T-Head's credits & coprights to the file?

I disagree to add the credits & copyrights of T-head. I'm now preparing a report to prove that they didn't provide much help to my contribution. I only referred to very limited code in my implementation, and the code are trivial.

@vpisarev
Copy link
Copy Markdown
Contributor Author

vpisarev commented Dec 14, 2020

@joy2myself, I suggest to discuss it privately

@vpisarev vpisarev changed the title added the credits & copyrights of ISCAS & T-head added the credits & copyrights of ISCAS Dec 17, 2020
@vpisarev vpisarev self-assigned this Dec 17, 2020
@vpisarev vpisarev marked this pull request as ready for review December 17, 2020 12:48
@vpisarev
Copy link
Copy Markdown
Contributor Author

vpisarev commented Dec 17, 2020

👍

@opencv-pushbot opencv-pushbot merged commit c51f5e8 into opencv:master Dec 17, 2020
@alalek alalek mentioned this pull request Apr 9, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@vpisarev vpisarev

Labels

platform: riscv

Projects

None yet

Milestone

4.5.1

Development

Successfully merging this pull request may close these issues.

5 participants

@vpisarev @joy2myself @opencv-pushbot @asmorkalov @alalek