Skip to content

videoio: turn off synchronized sink in GStreamer#19072

Merged
opencv-pushbot merged 1 commit intoopencv:3.4from
mshabunin:sink-sync-off
Dec 10, 2020
Merged

videoio: turn off synchronized sink in GStreamer#19072
opencv-pushbot merged 1 commit intoopencv:3.4from
mshabunin:sink-sync-off

Conversation

@mshabunin
Copy link
Copy Markdown
Contributor

Disabled synchronization with video stream rate for file/URI input in GStreamer VideoCapture backend. By default video decoding is performed with same rate as file FPS and manual pipeline configuration was required to avoid it.

related(?): #5766

Note: did not test it with cameras (v4l2://) and network streams (rstp://, http://, etc.).

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or other license that is incompatible with OpenCV
  • The PR is proposed to proper branch
  • There is reference to original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@mshabunin mshabunin changed the title videoio: turn off syncronized sink in GStreamer videoio: turn off synchronized sink in GStreamer Dec 10, 2020
Copy link
Copy Markdown
Member

@alalek alalek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍


if (!manualpipeline)
{
gst_base_sink_set_sync(GST_BASE_SINK(sink.get()), FALSE);
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

v4l2src

GStreamerCapture::open(int id) provides "manual" pipeline, so its behavior is not changed

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, but it is also possible to pass URI, e.g. v4l2:///dev/video1 which will create automatic pipeline with urisourcebin.

@opencv-pushbot opencv-pushbot merged commit 8ce08de into opencv:3.4 Dec 10, 2020
@alalek alalek mentioned this pull request Dec 11, 2020
@alalek alalek mentioned this pull request Apr 9, 2021
@mshabunin mshabunin deleted the sink-sync-off branch July 10, 2023 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants