Skip to content

dnn(caffe): add DetectionOutputParameter.clip to .proto file#19061

Merged
opencv-pushbot merged 1 commit intoopencv:3.4from
alalek:dnn_load_face_detector_with_external_protobuf
Dec 9, 2020
Merged

dnn(caffe): add DetectionOutputParameter.clip to .proto file#19061
opencv-pushbot merged 1 commit intoopencv:3.4from
alalek:dnn_load_face_detector_with_external_protobuf

Conversation

@alalek
Copy link
Copy Markdown
Member

@alalek alalek commented Dec 9, 2020

Allow to load opencv_face_detector model with external protobuf.
Builtin protobuf has patch with support for "custom" properties.

Validation instructions:

  • cmake -DBUILD_PROTOBUF=OFF -DPROTOBUF_UPDATE_FILES=ON ...
  • ./bin/opencv_test_dnn --gtest_filter=*opencv_face*

Note: .pb.cc / .pb.h files are not updated (not necessary and this update is large enough)

relates #18702

- allow to load opencv_face_detector with external unpatched protobuf
Copy link
Copy Markdown
Member

@dkurt dkurt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@opencv-pushbot opencv-pushbot merged commit 8286d84 into opencv:3.4 Dec 9, 2020
@alalek alalek mentioned this pull request Dec 9, 2020
@alalek alalek mentioned this pull request Apr 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants